fix: distinguish benchmark executable lookups from device calls - #471
Merged
Conversation
janicduplessis
marked this pull request as ready for review
September 7, 2026 09:10
This was referenced Sep 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
command -v agent-deviceonly locates the executable, but the benchmark audit reportsagent-device-run-session-not-applied. The per-command isolation guard still needs to reject actual unscoped invocations, not discovery arguments.Solution
Exclude literal executable lookups from the invocation audit. Chained unscoped commands and lookup arguments containing command substitutions remain rejected. This changes only post-run classification, not runner isolation, benchmark prompts, or execution pins.
Test plan
Regression cases cover
command -v/-V,which,type, andwhence, including redirected and shell-wrapped lookups. Negative cases retain rejection of unscoped commands after lookups, command substitutions, mismatched sessions, and daemon recovery.Fixes #470.